Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] handlers: Close file streams explicitly #202

Merged
merged 1 commit into from
Oct 25, 2020
Merged

[MRG] handlers: Close file streams explicitly #202

merged 1 commit into from
Oct 25, 2020

Conversation

tchx84
Copy link
Contributor

@tchx84 tchx84 commented Oct 22, 2020

No harm in closing these streams explicitly. Best case scenario, this prevents descriptors leaks, worse case scenario, it reduces the amount of messages like the following during tests: ResourceWarning: unclosed file

@tchx84
handlers: Close file streams explicitly
13a50e2 
No harm in closing these streams explicitly. Best case
scenario, this prevents descriptors leaks, worse case
scenario, it reduces the amount of  messages like the
following during tests:

ResourceWarning: unclosed file
@vinayak-mehta vinayak-mehta merged commit 8ca30f3 into camelot-dev:master Oct 25, 2020
@vinayak-mehta
Copy link
Member

💚 💙 💜 💛 ❤️

@vinayak-mehta
Copy link
Member

Thanks for catching and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchx84 @vinayak-mehta